Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: componentWillReceiveProps must be called before shouldComponentUpdate #1348

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fix: componentWillReceiveProps must be called before shouldComponentUpdate #1348

merged 2 commits into from
Mar 6, 2019

Conversation

mochiya98
Copy link
Contributor

No description provided.

marvinhagemeister
marvinhagemeister requested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your PR🎉 Only thing left to do is add a test case that verifies the change for future PRs👍💯

src/diff/index.js Show resolved Hide resolved
@mochiya98
Copy link
Contributor Author

sorry for delaying! I did it. 👍

marvinhagemeister
marvinhagemeister approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome! Thanks for adding a test case 👍💯

@marvinhagemeister marvinhagemeister merged commit cd6f005 into preactjs:master Mar 6, 2019
@mochiya98 mochiya98 deleted the fix-lifecycle-cwrp branch March 6, 2019 17:22
@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d8f9172 on mochiya98:fix-lifecycle-cwrp into 6e995b4 on developit:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochiya98 @coveralls @marvinhagemeister